[WebProfilerBundle] Use a dynamic SVG favicon in the profiler #48945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jan 11, 2023
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base.html.twig
Outdated
Show resolved
Hide resolved
stof
approved these changes
Jan 11, 2023
sazzabi-fcms
approved these changes
Jan 11, 2023
kbond
approved these changes
Jan 11, 2023
fabpot
approved these changes
Jan 11, 2023
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Jan 11, 2023
…rofiler (javiereguiluz) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [WebProfilerBundle] Use a dynamic SVG favicon in the profiler | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - The Profiler favicon looks blurry in high definition monitors. In this PR I propose: (1) To use a SVG icon instead (2) To make it dynamic to display a red or yellow background depending on the HTTP status code of the response This is how the colored favicons look on Chrome _(on the left you can see the current blurry icon)_: <img width="377" alt="svg-favicon-chrome" src="https://user-images.githubusercontent.com/73419/211763047-98f3742e-bc94-4ced-80ac-d02eb6fa4e96.png"> And this is how it looks on Firefox: <img width="540" alt="svg-favicon-firefox" src="https://user-images.githubusercontent.com/73419/211763095-99d7d4ac-8699-46c0-a3e6-2bbd667337bd.png"> About accessibility issues for color-blind people. I think this wouldn't be an issue because we're not using color as the only way of conveying information. It's just a little addition. But if you disagree I can revert. Thanks. Commits ------- e6c56a3 [WebProfilerBundle] Use a dynamic SVG favicon in the profiler
fabpot
force-pushed
the
profiler_favicon
branch
from
dff3209
to
e6c56a3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Profiler favicon looks blurry in high definition monitors. In this PR I propose:
(1) To use a SVG icon instead
(2) To make it dynamic to display a red or yellow background depending on the HTTP status code of the response
This is how the colored favicons look on Chrome (on the left you can see the current blurry icon):
And this is how it looks on Firefox:
About accessibility issues for color-blind people. I think this wouldn't be an issue because we're not using color as the only way of conveying information. It's just a little addition. But if you disagree I can revert. Thanks.