[FrameworkBundle] Rename service notifier.logger_notification_listener to notifier.notification_logger_listener
#48678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ker0x
commented
Dec 16, 2022
ker0x
commented
| Q | A |
|---|---|
| Branch? | 6.3 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | yes |
| Tickets | Fix #48519 |
| License | MIT |
| Doc PR | - |
OskarStark
changed the title
notifier.logger_notification_listener to notifier.notification_logger_listener
ker0x
force-pushed
the
issue-48519
branch
2 times, most recently
from
f09d8e5
to
278e1de
Compare
|
I'm moot here. Is this possibly used directly by anyone? If not can't we take a shortcut and change the name on 6.1? |
Possibly some |
| */ | ||
| public function testNotifierAssertion() | ||
| { | ||
| $this->expectDeprecation('Since symfony/framework-bundle 6.3: The "notifier.logger_notification_listener" service is deprecated, use "notifier.notification_logger_listener" instead.'); |
There was a problem hiding this comment.
A legacy test is one that should be removed in 7.0
Since that's not the case here, it means something is missing to not trigger the deprecation.
There was a problem hiding this comment.
I was unable to determine how to not trigger the depreciation, some help would be appreciated 😕!
…er` to `notifier.notification_logger_listener`
nicolas-grekas
force-pushed
the
issue-48519
branch
from
91811c8
to
fcbfbb1
Compare
|
Thank you @ker0x. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.