Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DoctrineBridge] Deprecate passing doctrine subscribers to ContainerAwa… #18181

Closed
fabpot opened this issue Apr 8, 2023 · 4 comments
Closed

[DoctrineBridge] Deprecate passing doctrine subscribers to ContainerAwa… #18181

fabpot opened this issue Apr 8, 2023 · 4 comments
Labels
DoctrineBridge hasPR A Pull Request has already been submitted for this issue.
Milestone
6.3

Comments

@fabpot
Copy link
Member

fabpot commented Apr 8, 2023

Q A
Feature PR symfony/symfony#49918
PR author(s) @alli83
Merged in 6.3

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 6.3 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 6.3 milestone Apr 8, 2023
@mdoutreluingne
Copy link
Contributor

I found no reference for ContainerAwareEventManager class in docs

@fabpot
Copy link
Member Author

fabpot commented Apr 9, 2023

Closing then.

@fabpot fabpot closed this as completed Apr 9, 2023
@stof
Copy link
Member

stof commented Jul 31, 2023

this is not passed explicitly in the doc, because the wiring is done by DoctrineBundle. But https://symfony.com/doc/current/doctrine/events.html#doctrine-lifecycle-subscribers still documents subscribers. So this should be reopened.

@lyrixx lyrixx mentioned this issue Jul 31, 2023
Closed
@javiereguiluz javiereguiluz reopened this Jul 31, 2023
@xabbuh xabbuh added hasPR A Pull Request has already been submitted for this issue. and removed hasPR A Pull Request has already been submitted for this issue. labels Aug 2, 2023
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Sep 18, 2023
@javiereguiluz javiereguiluz mentioned this issue Sep 18, 2023
Merged
javiereguiluz added a commit that referenced this issue Sep 19, 2023
@javiereguiluz
minor #18878 [Doctrine] Update the article about Doctrine events (jav…
4e93a70 
…iereguiluz)

This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Doctrine] Update the article about Doctrine events

Fixes #18650 and #18181.

Changes in this PR:

* Reworded the introduction to only explain the 3 types of listeners which are not deprecated and better explain why/when to use them according to #18650
* Reordered the explanation of the listeners to match the same order as in the intro: `Lifecycle callbacks` -> `Entity listeners` -> `Lifecycle listeners`
* Removed the contents about "Lifecycle Subscribers" because they are deprecated

Commits
-------

4a4d9de [Doctrine] Update the article about Doctrine events
@javiereguiluz
Copy link
Member

Closing as fixed in #18878.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DoctrineBridge hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
6.3
Development

No branches or pull requests
6 participants
@fabpot @javiereguiluz @stof @xabbuh @carsonbot @mdoutreluingne