Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DependencyInjection] Exclude referencing service (self) in `TaggedIter… #17656

Closed
fabpot opened this issue Jan 5, 2023 · 2 comments
Closed

[DependencyInjection] Exclude referencing service (self) in `TaggedIter… #17656

fabpot opened this issue Jan 5, 2023 · 2 comments
Labels
DependencyInjection hasPR A Pull Request has already been submitted for this issue.
Milestone
6.3

Comments

@fabpot
Copy link
Member

fabpot commented Jan 5, 2023

Q A
Feature PR symfony/symfony#48685
PR author(s) @chalasr
Merged in 6.3

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 6.3 branch in the symfony-docs repository.

Thank you! 😄
@fabpot fabpot added this to the 6.3 milestone Jan 5, 2023
@chalasr
Copy link
Member

chalasr commented Jan 6, 2023 •
edited

From what I see, this could be addressed by adding a small section presenting the exclude concept for tagged iterators and locators, mentioning the new default btw. If I'm right, that could be done in service_container/tags.rst next to Tagged Services with Index

@alexandre-daubois alexandre-daubois mentioned this issue Jan 10, 2023
Merged
OskarStark added a commit that referenced this issue Jan 11, 2023
@OskarStark
feature #17709 [DependencyInjection] Exclude referencing service (sel…
b589c82 
…f) in `TaggedIterator` (alexandre-daubois)

This PR was merged into the 6.3 branch.

Discussion
----------

[DependencyInjection] Exclude referencing service (self) in `TaggedIterator`

Closes #17656

Commits
-------

dd613a8 [DependencyInjection] Exclude referencing service (self) in `TaggedIterator`
@javiereguiluz
Copy link
Member

Closing as fixed in #17709.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Mar 17, 2023
@ruudk ruudk mentioned this issue Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DependencyInjection hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
6.3
Development

No branches or pull requests
5 participants
@fabpot @javiereguiluz @xabbuh @chalasr @carsonbot