[dx] drop twig 2.x support && open the door for 4.x #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
added
Related Tests Pass
Status: Needs Review
jrushlow
changed the title
|
Failing tests related to #1419 |
jrushlow
changed the title
jrushlow
force-pushed
the
feature/twig-support
branch
from
69c4a96
to
9609293
Compare
|
I like it - thanks Jesse! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twig 2.x reached EOL in December. Adding support for Twig 4.x.
4.x doesn't have a release yet so we have to do
4.x-devincomposer.jsonalternatively we could do>=v3.0. Either way, twig is a dev dependency so while adding 4.x support now may make our test suite slightly brittle, I don't think it would be of much a concern.