Update the UI for the mailbox viewer #822
Conversation
Apply Sweep Rules to your PR?
|
|
Thanks for the PR! Could you add a a couple screenshots to the description? I'm currently travelling and may have some trouble reviewing code / visual. I can tell that you swapped outdated bootstrap for custom tailwind styles. Appreciate the effort. 🙏 |
|
Thank you! I'll give it a good scan tomorrow and probably merge it. 💜 |
| <h6 class="list-group-item-heading"><%= render_recipient(email.from) %></h6> | ||
| <p class="list-group-item-text"><%= email.subject %></p> | ||
| <a href="<%= to_absolute_url(@conn, id) %>" class="flex flex-col border-b border-gray-200 p-4<%= if @email && @email.headers["Message-ID"] == id, do: " bg-gray-100" %>"> | ||
| <% {name, _email_address} = email.from %> |
There was a problem hiding this comment.
This would be empty in this case
There was a problem hiding this comment.
You're right, will fix
There was a problem hiding this comment.
No, actually render_value with show n/a for the empty string
|
@dsincl12 thanks for coming back to me so quickly. I'm happy to merge this now but will wait a bit to make a release. I intend to get to back to this to clean somethings up and play with the design a bit myself. I am busy the next 6 days or so, I will make a release maybe in a week. Cheers! |
|
I haven't got the time to play with the new UI. I decided to release it so the community can help polish it. ;) |
This will give the mailbox viewer a new UI.