-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/decorators): Fix init order of 2022-03
impl
#9760
Conversation
🦋 Changeset detectedLatest commit: c5de65c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@kdy1 please take a look on this draft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that this order change belongs to 2022-03
decorators?
I'm asking because the next version has initializer order reversed.
the only thing I changed in this PR is to move I can double check the 2022-03 specification |
CodSpeed Performance ReportMerging #9760 will degrade performances by 4.42%Comparing Summary
Benchmarks breakdown
|
82b91d4
to
36b63d5
Compare
I misunderstood the unit test, now it's fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests?
another question @kdy1, does swc have corporate CLA that my employer can sign? |
No, but I don’t think signing is necessary for this changes. I’m not going to monetize SWC or change license forever. I just want to be free while moving source codes in GitHub. I moved plugin codes from vercel/next.js to swc-project/plugins, and some npm packages within swc org, but that’s all. |
2022-03
impl
Description:
Fix the order of initialization for 2022-03 decorators.
TBH the proposal isn't very clear on how
init
is executed for auto-accessor decoratorRelated issue: