Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/typescript): Handle enum in single statement #9532

Merged
merged 3 commits into from
Sep 4, 2024
Merged

fix(es/typescript): Handle enum in single statement #9532

merged 3 commits into from
Sep 4, 2024
+161 −10

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari commented Sep 4, 2024 •
edited by kdy1
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: bb28e97

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@magic-akari magic-akari changed the title fix(es/typescript): Handle enum or namespace in single statement fix(es/typescript): Handle enum in single statement Sep 4, 2024
@magic-akari
fix(es/typescript): Handle enum in single statement
4010934
@magic-akari
chore: update test cases

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
ba61dcb
@magic-akari magic-akari marked this pull request as ready for review September 4, 2024 09:57
@magic-akari magic-akari requested a review from a team as a code owner September 4, 2024 09:57
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 4, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9532 will improve performances by 5.5%

Comparing magic-akari:fix/issue-9531 (bb28e97) with main (c7fdd6b)

Summary

⚡ 1 improvements
✅ 177 untouched benchmarks

Benchmarks breakdown

Benchmark main magic-akari:fix/issue-9531 Change
⚡ es/full/codegen/es2015 290.8 µs 275.6 µs +5.5%

@kdy1 kdy1 added this to the Planned milestone Sep 4, 2024
@kdy1
Create fresh-zoos-act.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
bb28e97
@kdy1 kdy1 requested a review from a team as a code owner September 4, 2024 11:55
@kdy1 kdy1 merged commit 84b0043 into swc-project:main Sep 4, 2024
5 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.24 Sep 8, 2024
@magic-akari magic-akari deleted the fix/issue-9531 branch September 9, 2024 02:28
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1

Assignees
No one assigned
Labels
None yet
Milestone
v1.7.24
Development

Successfully merging this pull request may close these issues.

The single statement containing the TS Enum is not being transformed
2 participants
@magic-akari @kdy1