Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/resolver): Prioritze jsc.paths by length in tsc resolver #8875

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

yehonatanz
Copy link
Contributor

@yehonatanz yehonatanz commented Apr 18, 2024

Description:

See #8858

BREAKING CHANGE:
jsc.paths are now prioritized differently to align with tsc. The order is:

  1. Exact matches
  2. Wildcard pattern matches, sorted by length of prefix before wildcard

Related issue:

@yehonatanz yehonatanz requested a review from a team as a code owner April 18, 2024 10:46
Copy link

changeset-bot bot commented Apr 18, 2024

⚠️ No Changeset found

Latest commit: 4236d31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_core
  • swc_ecma_loader

@kdy1 kdy1 enabled auto-merge (squash) April 19, 2024 12:50
@kdy1 kdy1 disabled auto-merge April 19, 2024 12:50
@kdy1 kdy1 changed the title fix(tsc-resolver): Prioritze jsc.paths by length in tsc resolver fix(es/resolver): Prioritze jsc.paths by length in tsc resolver Apr 19, 2024
@kdy1 kdy1 enabled auto-merge (squash) April 19, 2024 12:51
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit e22c368 into swc-project:main Apr 19, 2024
149 of 290 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.4.17 Apr 23, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

swc does not prioritize jsc.paths by matching prefix length like tsc specifies
4 participants