Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/bugfixes): Fix fn transform in nameless fns #8796

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

AlfonzAlfonz
Copy link
Contributor

@AlfonzAlfonz AlfonzAlfonz commented Apr 1, 2024

Description:

This pull request fixes bugfix/transform-safari-id-destructuring-collision-in-function-expression module. Previously the transform ignored code inside of function which did not have specified identifier. Now the visitor should go through the content of the nameless functions.

Related issue:

@AlfonzAlfonz AlfonzAlfonz requested a review from a team as a code owner April 1, 2024 22:34
Copy link

changeset-bot bot commented Apr 1, 2024

⚠️ No Changeset found

Latest commit: 629035b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_compat_bugfixes
  • swc_core

@kdy1 kdy1 added this to the Planned milestone Apr 2, 2024
@kdy1 kdy1 merged commit 7ad004e into swc-project:main Apr 2, 2024
142 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.4.12 Apr 4, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants