Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/parser): Tweak msg of SyntaxError::UsingDeclNotEnabled #8791

Merged
merged 2 commits into from
Apr 1, 2024
Merged

fix(es/parser): Tweak msg of SyntaxError::UsingDeclNotEnabled #8791

merged 2 commits into from
Apr 1, 2024

Conversation

TrickyPi
Copy link
Contributor

Description:
Tweak the msg, the option jsc.parser.usingDecl has been replaced by jsc.parser.explicitResourceManagement

BREAKING CHANGE:

Related issue (if exists):

@TrickyPi TrickyPi requested a review from a team as a code owner March 30, 2024 05:15
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2024 •
edited

⚠️ No Changeset found

Latest commit: 1cf564d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kdy1
kdy1 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_core
  • swc_ecma_parser

@kdy1 kdy1 self-assigned this Apr 1, 2024
@kdy1 kdy1 added this to the Planned milestone Apr 1, 2024
@kdy1 kdy1 changed the title Tweak the msg of SyntaxError::UsingDeclNotEnabled fix(es/parser): Tweak msg of SyntaxError::UsingDeclNotEnabled Apr 1, 2024
@kdy1 kdy1 enabled auto-merge (squash) April 1, 2024 01:03
swc-bot
swc-bot reviewed Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 95c822e into swc-project:main Apr 1, 2024
142 checks passed
@TrickyPi TrickyPi deleted the chore/using-decl-msg branch April 1, 2024 11:08
@kdy1 kdy1 modified the milestones: Planned, v1.4.12 Apr 4, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.4.12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TrickyPi @kdy1 @swc-bot