-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(common): Debug-print spans more compactly #8746
Conversation
|
|
This fails a bunch of tests under |
|
|
Seems like that `.stdout` file was not used, so I'm just gonna delete it.
Took a while to figure out how to run the tests, but there we go. Those jsdoc fixtures went from 48093 to 17173 lines, a 64% reduction. Also the Massively changes the size of this PR though. Funny how that works sometimes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- swc_common
Description:
dbg!()
output on ASTs is kinda verbose,A lot of the space is wasted on spans — 9 lines per span, even though it's pretty much unimportant cruft. This PR changes that to just one line per span:
While not a statistically meaningful measurement, in my tests (sample size = 1) this change reduces the
dbg!()
of a 1103-byte script from 5597 to 2885 lines, which is a 48% reduction. In{:?}
mode it goes from 40034 to 25457 chars, or 37% reduction.BREAKING CHANGE:
None,
Debug
output is generally not considered stable.Related issue (if exists):
None known.