Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(es): Prepare wasm32-wasi-preview1-threads target support #8724

Merged
merged 1 commit into from
Mar 11, 2024
Merged

refactor(es): Prepare wasm32-wasi-preview1-threads target support #8724

merged 1 commit into from
Mar 11, 2024
+921 −940

Conversation

Brooooooklyn
Copy link
Member

PathBuf and rayon is usable in wasm32-wasi-preview1-threads target, so we can enable it.

@Brooooooklyn Brooooooklyn requested review from a team as code owners March 10, 2024 15:40
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2024 •
edited

⚠️ No Changeset found

Latest commit: c020c8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kdy1
kdy1 requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed

.yarnrc.yml Outdated Show resolved Hide resolved
@Brooooooklyn Brooooooklyn requested a review from kdy1 March 11, 2024 04:23
@kdy1 kdy1 changed the title chore: prepare to support the wasm32-wasi-preview1-threads target refactor(es): Prepare wasm32-wasi-preview1-threads target support Mar 11, 2024
@kdy1 kdy1 merged commit e3acd14 into main Mar 11, 2024
140 of 141 checks passed
@kdy1 kdy1 deleted the chore/prepare-wasi-target branch March 11, 2024 04:27
kdy1
kdy1 reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_base

@kdy1 kdy1 modified the milestones: Planned, v1.4.7 Mar 11, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.4.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Brooooooklyn @kdy1