Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/lints): Add no-prototype-builtins rule #8684

Merged
merged 7 commits into from Mar 11, 2024
Merged

feat(es/lints): Add no-prototype-builtins rule #8684

merged 7 commits into from Mar 11, 2024

Conversation

ArturAralin
Copy link
Contributor

Description:

Add no-prototype-builtins rule implementation

BREAKING CHANGE:

No breaking changes

@ArturAralin ArturAralin requested a review from a team as a code owner March 3, 2024 11:10
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2024 •
edited

⚠️ No Changeset found

Latest commit: 9b33d1f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ArturAralin ArturAralin changed the title feat(es/lints): add no-prototype-builtins feat(es/lints): Add no-prototype-builtins rule Mar 3, 2024
@kdy1 kdy1 self-assigned this Mar 4, 2024
kdy1
kdy1 requested changes Mar 4, 2024
View reviewed changes
crates/swc/tests/error_msg.rs Outdated Show resolved Hide resolved
@kdy1 kdy1 added this to the Planned milestone Mar 4, 2024
kdy1
kdy1 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the logic, but approving based on the tests.

swc-bump:

  • swc_ecma_lints

kdy1
kdy1 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the logic, but approving based on the tests.

swc-bump:

  • swc_ecma_lints

@kdy1 kdy1 enabled auto-merge (squash) March 11, 2024 03:50
swc-bot
swc-bot reviewed Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit a5dbb17 into swc-project:main Mar 11, 2024
142 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.4.7 Mar 13, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.4.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArturAralin @kdy1 @swc-bot