Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/minifier): Remove unused parameters of arrow functions #8636

Merged
merged 7 commits into from
Feb 14, 2024
Merged

feat(es/minifier): Remove unused parameters of arrow functions #8636

merged 7 commits into from
Feb 14, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 13, 2024

@kdy1 kdy1 added this to the Planned milestone Feb 13, 2024
@kdy1 kdy1 self-assigned this Feb 13, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2024 •
edited

⚠️ No Changeset found

Latest commit: 0a364b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kdy1
kdy1 commented Feb 13, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 marked this pull request as ready for review February 13, 2024 06:42
@kdy1 kdy1 requested a review from a team as a code owner February 13, 2024 06:42
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 13, 2024
View reviewed changes
@kdy1 kdy1 changed the title feat(es/minifier): Remove unused parameters feat(es/minifier): Remove unused parameters of arrow functions Feb 13, 2024
@kdy1 kdy1 enabled auto-merge (squash) February 14, 2024 01:25
@kdy1 kdy1 disabled auto-merge February 14, 2024 01:26
@kdy1 kdy1 enabled auto-merge (squash) February 14, 2024 01:30
swc-bot
swc-bot reviewed Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 8cd4813 into swc-project:main Feb 14, 2024
142 checks passed
@kdy1 kdy1 deleted the issue-8626 branch February 14, 2024 02:09
@kdy1 kdy1 modified the milestones: Planned, v1.4.2 Feb 19, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.

swc does not remove unused arguments during minification
2 participants
@kdy1 @swc-bot