Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/resolver): Skip property in JSX member #8598

Merged
merged 2 commits into from
Feb 4, 2024
Merged

fix(es/resolver): Skip property in JSX member #8598

merged 2 commits into from
Feb 4, 2024

Conversation

magic-akari
Copy link
Member

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2024

⚠️ No Changeset found

Latest commit: e42786e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@magic-akari magic-akari marked this pull request as ready for review February 4, 2024 05:39
@magic-akari magic-akari requested a review from a team as a code owner February 4, 2024 05:39
kdy1
kdy1 approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_visit

@kdy1 kdy1 enabled auto-merge (squash) February 4, 2024 05:56
@kdy1 kdy1 changed the title fix(es/resolver): Skip prop in JSX member fix(es/resolver): Skip property in JSX member Feb 4, 2024
@kdy1 kdy1 added this to the Planned milestone Feb 4, 2024
@kdy1 kdy1 merged commit d480ab9 into swc-project:main Feb 4, 2024
141 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.4.0 Feb 5, 2024
@magic-akari magic-akari deleted the fix/issue-8528 branch February 20, 2024 12:35
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

SWC incorrectly adds underscore to imported star import
2 participants
@magic-akari @kdy1