Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/lexer): Fix typo in package keyword #8589

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

yannkaiser
Copy link
Contributor

@yannkaiser yannkaiser commented Feb 1, 2024

Description:

There is a typo in the ES lexer for the keyword package.

Related issue:

@yannkaiser yannkaiser requested a review from a team as a code owner February 1, 2024 19:57
Copy link

changeset-bot bot commented Feb 1, 2024

⚠️ No Changeset found

Latest commit: 389c40e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Feb 1, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 changed the title fix(es/lexer): fix typo in package keyword fix(es/lexer): Fix typo in package keyword Feb 2, 2024
@kdy1 kdy1 enabled auto-merge (squash) February 2, 2024 00:43
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge February 2, 2024 01:17
@kdy1 kdy1 merged commit 8413a6c into swc-project:main Feb 2, 2024
140 of 141 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.4.0 Feb 5, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Typo in lexer table for the keyword package
4 participants