Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/minifier): Respect more options #8582

Merged
merged 32 commits into from
Feb 2, 2024
Merged

feat(es/minifier): Respect more options #8582

merged 32 commits into from
Feb 2, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 1, 2024 •
edited

Description:

This PR makes the ES minifier respect more options.

Changes:

  • reduce_vars now enables IIFE invoker.
  • reduce_vars now enables seq inliner.
  • top_retain is now respected by seq inliner.
  • arguments is now ignored by seq inliner.

@kdy1 kdy1 added this to the Planned milestone Feb 1, 2024
@kdy1 kdy1 self-assigned this Feb 1, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2024 •
edited

⚠️ No Changeset found

Latest commit: 5bb6e5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 changed the title feat(es/minifier): Respect option feat(es/minifier): Respect options Feb 1, 2024
@kdy1 kdy1 changed the title feat(es/minifier): Respect options feat(es/minifier): Improve minifier Feb 1, 2024
@kdy1 kdy1 changed the title feat(es/minifier): Improve minifier feat(es/minifier): Respect more options Feb 1, 2024
@kdy1 kdy1 mentioned this pull request Feb 2, 2024
Merged
@kdy1 kdy1 marked this pull request as ready for review February 2, 2024 02:15
@kdy1 kdy1 requested a review from a team as a code owner February 2, 2024 02:15
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 2, 2024
View reviewed changes
kdy1
kdy1 commented Feb 2, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 2, 2024
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 2, 2024
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 2, 2024
View reviewed changes
@kdy1 kdy1 requested a review from Austaras February 2, 2024 06:15
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 2, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) February 2, 2024 08:35
@kdy1
Copy link
Member Author

kdy1 commented Feb 2, 2024

Thank you!

@kdy1 kdy1 merged commit fd997d3 into swc-project:main Feb 2, 2024
141 checks passed
@kdy1 kdy1 deleted the comp-rate-2 branch February 2, 2024 12:35
@kdy1 kdy1 modified the milestones: Planned, v1.4.0 Feb 5, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Austaras Austaras Austaras approved these changes

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdy1 @Austaras