Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli/plugin): cli plugin target wasm32-wasip1 #10293

Merged
merged 10 commits into from
Mar 30, 2025

Conversation

genskyff
Copy link
Contributor

Description:

Fixed the error where the target type behavior was inconsistent with the documentation when creating a plugin using CLI. Now wasm32-wasip1 can be used normally as a target.

❯ cargo run -p swc_cli_impl -- plugin new --target-type wasm32-wasip1 my-first-plugin
     Running `target\debug\swc.exe plugin new --target-type wasm32-wasip1 my-first-plugin`
✅ Successfully created my-first-plugin.
If you haven't, please ensure to add target via "rustup target add wasm32-wasip1"

BREAKING CHANGE:

Related issue (if exists):

@genskyff genskyff requested a review from a team as a code owner March 30, 2025 07:28
Copy link

changeset-bot bot commented Mar 30, 2025

🦋 Changeset detected

Latest commit: af0e0ff

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codspeed-hq bot commented Mar 30, 2025

CodSpeed Performance Report

Merging #10293 will degrade performances by 1.05%

Comparing genskyff:fix/10284-cli-target-wasip1 (af0e0ff) with main (c276a38)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 150 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
serialization of serde 2.8 µs 2.8 µs -1.05%
es/lints/libs/terser 30 ms 29.3 ms +2.46%

@kdy1 kdy1 added this to the Planned milestone Mar 30, 2025
@kdy1 kdy1 self-assigned this Mar 30, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kdy1 kdy1 merged commit 7daf4f4 into swc-project:main Mar 30, 2025
33 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.11.14 Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants