Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts/fast-strip): Add start/end span information #10251

Merged
merged 3 commits into from
Mar 23, 2025
Merged

feat(ts/fast-strip): Add start/end span information #10251

merged 3 commits into from
Mar 23, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 23, 2025

Description:

Note: This PR does not include a fix for the parser diagnostics.

Related issue:

kdy1 added 3 commits March 23, 2025 17:55

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kdy1 kdy1 added this to the Planned milestone Mar 23, 2025
@kdy1 kdy1 self-assigned this Mar 23, 2025
@kdy1 kdy1 requested a review from a team as a code owner March 23, 2025 08:59
Copy link

changeset-bot bot commented Mar 23, 2025

⚠️ No Changeset found

Latest commit: 31cc7bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 enabled auto-merge (squash) March 23, 2025 08:59
@marco-ippolito
Copy link
Contributor

What is an example of multiline errors that require startLine and endLine?

Copy link

codspeed-hq bot commented Mar 23, 2025

CodSpeed Performance Report

Merging #10251 will degrade performances by 2.08%

Comparing kdy1/span (31cc7bf) with main (549e38d)

Summary

❌ 4 regressions
✅ 148 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
serialization of serde 2.8 µs 2.8 µs -2.08%
es/lints/libs/d3 27.8 ms 28.2 ms -1.62%
es/lints/libs/terser 29.6 ms 30.1 ms -1.7%
es/minifier/libs/terser 413.8 ms 418.1 ms -1.03%

@kdy1 kdy1 merged commit ab39a62 into main Mar 23, 2025
169 checks passed
@kdy1 kdy1 deleted the kdy1/span branch March 23, 2025 09:26
@kdy1
Copy link
Member Author

kdy1 commented Mar 23, 2025

@marco-ippolito

enum Foo {
}

@kdy1 kdy1 modified the milestones: Planned, v1.11.12 Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

@swc/wasm-typescript error snippet not working
2 participants