Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/minifier): Remove needless blocks #10234

Merged
merged 2 commits into from
Mar 20, 2025
Merged

feat(es/minifier): Remove needless blocks #10234

merged 2 commits into from
Mar 20, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 20, 2025

Description:

I postponed this while working on dead_branch_remover removal PR.

kdy1 added 2 commits March 20, 2025 20:01

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Unverified

This user has not yet uploaded their public signing key.
@kdy1 kdy1 added this to the Planned milestone Mar 20, 2025
@kdy1 kdy1 self-assigned this Mar 20, 2025
@kdy1 kdy1 requested a review from a team as a code owner March 20, 2025 11:04
Copy link

changeset-bot bot commented Mar 20, 2025

⚠️ No Changeset found

Latest commit: 51047ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 enabled auto-merge (squash) March 20, 2025 11:07
Copy link

codspeed-hq bot commented Mar 20, 2025

CodSpeed Performance Report

Merging #10234 will improve performances by 2.75%

Comparing kdy1/block (51047ce) with main (6841523)

Summary

⚡ 3 improvements
✅ 149 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
serialization of serde 2.8 µs 2.8 µs +1.06%
es/lints/libs/terser 30.3 ms 29.4 ms +2.75%
es/minifier/libs/react 24.3 ms 24.1 ms +1.12%

@kdy1 kdy1 merged commit 0817970 into main Mar 20, 2025
169 checks passed
@kdy1 kdy1 deleted the kdy1/block branch March 20, 2025 11:34
kdy1 added a commit that referenced this pull request Mar 20, 2025
kdy1 added a commit that referenced this pull request Mar 20, 2025
This reverts commit 7db84c3.
@kdy1 kdy1 modified the milestones: Planned, v1.11.12 Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant