Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/minifier): Default to the smallest size #10218

Merged
merged 5 commits into from
Mar 17, 2025
Merged

feat(es/minifier): Default to the smallest size #10218

merged 5 commits into from
Mar 17, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 17, 2025

Description:

AFAIK all bundlers used in production support extracting license comments. We can default to the smallest size, I think.

@kdy1 kdy1 added this to the Planned milestone Mar 17, 2025
@kdy1 kdy1 self-assigned this Mar 17, 2025
@kdy1 kdy1 requested a review from a team as a code owner March 17, 2025 14:30
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 17, 2025
Copy link

changeset-bot bot commented Mar 17, 2025

🦋 Changeset detected

Latest commit: c645a36

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kdy1 kdy1 requested a review from a team as a code owner March 17, 2025 14:30
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 17, 2025
@kdy1 kdy1 changed the title feat(es/minifier): Default to smallest size feat(es/minifier): Default to the smallest size Mar 17, 2025
Copy link

codspeed-hq bot commented Mar 17, 2025

CodSpeed Performance Report

Merging #10218 will degrade performances by 2.17%

Comparing kdy1/min-default (c645a36) with main (1dcdbbc)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 149 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
serialization of serde 2.8 µs 2.8 µs +1.06%
es/lints/libs/d3 27.7 ms 28.4 ms -2.17%
es/lints/libs/terser 29.6 ms 30 ms -1.28%

kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 17, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kdy1 kdy1 merged commit 800f51a into main Mar 17, 2025
169 checks passed
@kdy1 kdy1 deleted the kdy1/min-default branch March 17, 2025 16:18
@kdy1
Copy link
Member Author

kdy1 commented Mar 17, 2025

Side note: If this looks like a problem, feel free to tell me. I can revert/invert this PR.

@kdy1 kdy1 modified the milestones: Planned, v1.11.11 Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant