Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(es/minifier): Move some deps to dev deps #10216

Merged
merged 13 commits into from
Mar 17, 2025
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 17, 2025

Description:

I made a mistake. This PR also adds a size test for the swc crate, to ensure that the issue described in privatenumber/minification-benchmarks#664 is not our fault.

@kdy1 kdy1 added this to the Planned milestone Mar 17, 2025
@kdy1 kdy1 self-assigned this Mar 17, 2025
Copy link

changeset-bot bot commented Mar 17, 2025

🦋 Changeset detected

Latest commit: 55e6ddf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review March 17, 2025 12:59
@kdy1 kdy1 requested review from a team as code owners March 17, 2025 12:59
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 17, 2025
@kdy1 kdy1 enabled auto-merge (squash) March 17, 2025 13:00
Copy link

codspeed-hq bot commented Mar 17, 2025

CodSpeed Performance Report

Merging #10216 will degrade performances by 1.21%

Comparing kdy1/swc-crate-minify (55e6ddf) with main (80ccd86)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 150 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/lints/libs/terser 29.4 ms 29 ms +1.35%
es/minifier/libs/terser 425.8 ms 431 ms -1.21%

@kdy1 kdy1 disabled auto-merge March 17, 2025 13:33
@kdy1 kdy1 merged commit 1dcdbbc into main Mar 17, 2025
168 checks passed
@kdy1 kdy1 deleted the kdy1/swc-crate-minify branch March 17, 2025 13:33
@kdy1 kdy1 modified the milestones: Planned, v1.11.11 Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant