Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(es/minifier): Remove full tests with too large input #10213

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 17, 2025

Description:

As suggested with #10208 (comment). It's nearly impossible to read this to debug stuffs.

@kdy1 kdy1 added this to the Planned milestone Mar 17, 2025
@kdy1 kdy1 self-assigned this Mar 17, 2025
@kdy1 kdy1 requested a review from a team as a code owner March 17, 2025 08:44
Copy link

changeset-bot bot commented Mar 17, 2025

⚠️ No Changeset found

Latest commit: a2463e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 requested a review from Austaras March 17, 2025 08:44
@kdy1 kdy1 enabled auto-merge (squash) March 17, 2025 08:52
Copy link

codspeed-hq bot commented Mar 17, 2025

CodSpeed Performance Report

Merging #10213 will improve performances by 4.46%

Comparing kdy1/remove-mapbox (a2463e8) with main (f28d96e)

Summary

⚡ 3 improvements
✅ 149 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
serialization of serde 2.8 µs 2.8 µs +1.06%
es/lints/libs/d3 28.2 ms 27.9 ms +1.01%
es/lints/libs/terser 30.5 ms 29.2 ms +4.46%

@kdy1 kdy1 disabled auto-merge March 17, 2025 09:13
@kdy1 kdy1 merged commit 99b590f into main Mar 17, 2025
168 checks passed
@kdy1 kdy1 deleted the kdy1/remove-mapbox branch March 17, 2025 09:13
@kdy1 kdy1 modified the milestones: Planned, v1.11.11 Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants