Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Do not drop numbers incorrectly #10211

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 17, 2025

Description:

Previously, numbers could be dropped wrongly if they were not zero-valued. It's not realistic inreal-worldworld source code, but it is still a bug.

Copy link

changeset-bot bot commented Mar 17, 2025

⚠️ No Changeset found

Latest commit: 12c2d2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member Author

kdy1 commented Mar 17, 2025

Copy link

codspeed-hq bot commented Mar 17, 2025

CodSpeed Performance Report

Merging #10211 will improve performances by 2.46%

Comparing kdy1/fix-min-drop-number (12c2d2f) with main (99b590f)

Summary

⚡ 2 improvements
✅ 150 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
es/lints/libs/d3 28.7 ms 28 ms +2.46%
es/lints/libs/terser 30.6 ms 29.9 ms +2.2%

@kdy1 kdy1 changed the title drop_number fix(es/minifier): Do not drop numbers incorrectly Mar 17, 2025
@kdy1 kdy1 marked this pull request as ready for review March 17, 2025 08:24
@kdy1 kdy1 requested a review from a team as a code owner March 17, 2025 08:24
@kdy1 kdy1 force-pushed the kdy1/fix-min-drop-number branch from d958be4 to a650278 Compare March 17, 2025 08:26
@kdy1 kdy1 force-pushed the kdy1/fix-min-drop-number branch from a650278 to ef3d0ab Compare March 17, 2025 08:34
@kdy1 kdy1 self-assigned this Mar 17, 2025
@kdy1 kdy1 added this to the Planned milestone Mar 17, 2025
@kdy1 kdy1 changed the base branch from kdy1/ast-api to graphite-base/10211 March 17, 2025 09:10
@kdy1 kdy1 force-pushed the kdy1/fix-min-drop-number branch from ef3d0ab to e09c2ae Compare March 17, 2025 09:10
@kdy1 kdy1 force-pushed the graphite-base/10211 branch from a4fec4d to 8eb87ba Compare March 17, 2025 09:10
@graphite-app graphite-app bot changed the base branch from graphite-base/10211 to main March 17, 2025 09:11
@kdy1 kdy1 force-pushed the kdy1/fix-min-drop-number branch from e09c2ae to 88e5022 Compare March 17, 2025 09:11

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@kdy1 kdy1 force-pushed the kdy1/fix-min-drop-number branch from 88e5022 to 12c2d2f Compare March 17, 2025 09:39
@kdy1 kdy1 merged commit 80ccd86 into main Mar 17, 2025
170 checks passed
@kdy1 kdy1 deleted the kdy1/fix-min-drop-number branch March 17, 2025 10:14
@kdy1 kdy1 modified the milestones: Planned, v1.11.11 Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant