-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(es/minifier): Test only sizes for large inputs #10208
Conversation
|
CodSpeed Performance ReportMerging #10208 will degrade performances by 1.88%Comparing Summary
Benchmarks breakdown
|
Wait, I believe it's really helpful to have these full sized js in test. They could reveal many corner cases in complex scenario. @kdy1 I believe we shall revert this. |
We should removed minified tests instead like mapbox and some other. |
@Austaras I'll add back them via another PR, thanks for the notice! |
**Description:** It helps to catch an edge case, so let's have it in the repository, along with the new size tests **Related issue:** - This PR inverts #10208
**Description:** As suggested with #10208 (comment). It's nearly impossible to read this to debug stuffs.
Description:
Large output results are not helpful for catching errors