Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(es/minifier): Test only sizes for large inputs #10208

Merged
merged 30 commits into from
Mar 17, 2025
Merged

test(es/minifier): Test only sizes for large inputs #10208

merged 30 commits into from
Mar 17, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 17, 2025

Description:

Large output results are not helpful for catching errors

kdy1 added 28 commits March 17, 2025 13:52

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
DEp

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
CI
@kdy1 kdy1 added this to the Planned milestone Mar 17, 2025
@kdy1 kdy1 self-assigned this Mar 17, 2025
@kdy1 kdy1 marked this pull request as ready for review March 17, 2025 05:20
@kdy1 kdy1 requested review from a team as code owners March 17, 2025 05:20
Copy link

changeset-bot bot commented Mar 17, 2025

⚠️ No Changeset found

Latest commit: 216575f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 17, 2025
@kdy1 kdy1 enabled auto-merge (squash) March 17, 2025 05:20
kdy1 added 2 commits March 17, 2025 14:21
@kdy1 kdy1 disabled auto-merge March 17, 2025 05:33
@kdy1 kdy1 merged commit bec3e3e into main Mar 17, 2025
167 checks passed
@kdy1 kdy1 deleted the kdy1/min-only branch March 17, 2025 05:34
Copy link

codspeed-hq bot commented Mar 17, 2025

CodSpeed Performance Report

Merging #10208 will degrade performances by 1.88%

Comparing kdy1/min-only (216575f) with main (e71b000)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 150 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/lints/libs/d3 28.2 ms 28.7 ms -1.88%
es/lints/libs/terser 29.6 ms 29.2 ms +1.18%

@kdy1 kdy1 modified the milestones: Planned, v1.11.10 Mar 17, 2025
@Austaras
Copy link
Member

Wait, I believe it's really helpful to have these full sized js in test. They could reveal many corner cases in complex scenario. @kdy1 I believe we shall revert this.

@Austaras
Copy link
Member

We should removed minified tests instead like mapbox and some other.

@kdy1
Copy link
Member Author

kdy1 commented Mar 17, 2025

@Austaras I'll add back them via another PR, thanks for the notice!

kdy1 added a commit that referenced this pull request Mar 17, 2025
**Description:**

It helps to catch an edge case, so let's have it in the repository, along with the new size tests

**Related issue:**

 - This PR inverts #10208
kdy1 added a commit that referenced this pull request Mar 17, 2025
**Description:**

As suggested with #10208 (comment). It's nearly impossible to read this to debug stuffs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants