Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Check assign target before merge assign cond #10020

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

Austaras
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@Austaras Austaras requested a review from a team as a code owner February 10, 2025 08:18
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 0a90c1b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Feb 10, 2025

CodSpeed Performance Report

Merging #10020 will degrade performances by 6.14%

Comparing Austaras:main (0a90c1b) with main (7d7319f)

Summary

⚡ 3 improvements
❌ 2 regressions
✅ 191 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/jquery 162.9 ms 170.3 ms -4.35%
es/full/minify/libraries/lodash 188.2 ms 179.9 ms +4.6%
es/full/minify/libraries/vue 235.8 ms 226.1 ms +4.27%
es/minifier/libs/jquery 135.4 ms 128.1 ms +5.69%
es/minifier/libs/lodash 145.2 ms 154.7 ms -6.14%

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
@kdy1 kdy1 requested a review from a team as a code owner February 10, 2025 20:30
@kdy1 kdy1 added this to the Planned milestone Feb 10, 2025
@kdy1 kdy1 enabled auto-merge (squash) February 10, 2025 20:31
@kdy1 kdy1 merged commit 6dab49a into swc-project:main Feb 10, 2025
170 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.10.17 Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants