Skip to content

Commit fbad136

Browse files
authoredJan 16, 2025
refactor(es/minifier): Make minify-all profilable (#9888)
**Description:** I modified it to minify 10 times so I can profile it.
1 parent 197f0bc commit fbad136

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed
 

‎crates/swc_ecma_minifier/examples/minify-all.rs

+7-6
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,11 @@ fn main() {
2626
let files = expand_dirs(dirs);
2727
eprintln!("Using {} files", files.len());
2828

29-
let start = Instant::now();
30-
minify_all(files);
31-
32-
eprintln!("Took {:?}", start.elapsed());
29+
for i in 0..10 {
30+
let start = Instant::now();
31+
minify_all(&files);
32+
eprintln!("{}: Took {:?}", i, start.elapsed());
33+
}
3334
}
3435

3536
/// Return the whole input files as abolute path.
@@ -65,11 +66,11 @@ impl Parallel for Worker {
6566
}
6667

6768
#[inline(never)] // For profiling
68-
fn minify_all(files: Vec<PathBuf>) {
69+
fn minify_all(files: &[PathBuf]) {
6970
GLOBALS.set(&Default::default(), || {
7071
Worker.maybe_par(2, files, |_, path| {
7172
testing::run_test(false, |cm, handler| {
72-
let fm = cm.load_file(&path).expect("failed to load file");
73+
let fm = cm.load_file(path).expect("failed to load file");
7374

7475
let unresolved_mark = Mark::new();
7576
let top_level_mark = Mark::new();

‎crates/swc_ecma_minifier/src/util/base54.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ impl Visit for CharFreqAnalyzer<'_> {
301301
visit_obj_and_computed!();
302302

303303
fn visit_ident(&mut self, i: &Ident) {
304-
if i.sym != "arguments" && i.ctxt == self.unresolved_ctxt {
304+
if i.ctxt == self.unresolved_ctxt && i.sym != "arguments" {
305305
return;
306306
}
307307

0 commit comments

Comments
 (0)