Include CPU arch in the cache key for arm64 Linux runners #228
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysd
changed the title
Swatinem
approved these changes
Feb 8, 2025
|
I don't suppose you could release a new rust-cache version with this fix? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub announced Linux arm64 hosted runners.
Now GitHub Actions supports both x86_64 and arm64 for Linux. However rust-cache action doesn't include the CPU arch in the cache key. For example:
This PR includes CPU arch in the generated cache key so that it can ensure different caches are created on different CPU architectures and they are not mixed up.