Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add logging to Cargo.lock/Cargo.toml hashing #156

Merged
merged 1 commit into from
Aug 4, 2023
Merged

feat: Add logging to Cargo.lock/Cargo.toml hashing #156

merged 1 commit into from
Aug 4, 2023

Conversation

NobodyXu
Copy link
Contributor

@NobodyXu NobodyXu commented Aug 4, 2023

There are a few problems in cargo-binstall where sometimes change to Cargo.lock does not invalidate the cache.

Copy link
Owner

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m a bit unsure if this helps. You say that changes to Cargo.lock do not lead to a new cache key, but these fallback paths will consider the entire Cargo.lock.

package.json Outdated Show resolved Hide resolved
src/config.ts Show resolved Hide resolved
@NobodyXu NobodyXu requested a review from Swatinem August 4, 2023 10:07
package-lock.json Outdated Show resolved Hide resolved
There are a few problems in cargo-binstall where sometimes change to
`Cargo.lock` does not invalidate the cache.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@Swatinem Swatinem merged commit b919e14 into Swatinem:master Aug 4, 2023
22 checks passed
@NobodyXu NobodyXu deleted the add/loging branch August 4, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants