feat: Rm workspace crates version before caching

[NobodyXu]

Fixed #146

• Set all package.version in Cargo.toml to 0.0.0
• Set {build-, dev-, }dependencies of workspace crates to 0.0.0
• Remove workspace crates from Cargo.lock before caching
• Sort all toml objects before hashing them as json

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

[Swatinem]

This is a really interesting approach, and I believe this works, as we are indeed only interested in non-workspace crates.

Can you check that the relevant files are still listed in the info output of the action?

Also, I think you would have to do the same filtering/nulling of workspace dependencies in the Cargo.toml files, as you can have dependencies such as workspace-crate = { path = "path/for/local/development", version = "1.0.0-version-for-installing-via-cratesio" }

[NobodyXu]

Can you check that the relevant files are still listed in the info output of the action?

Sorry I am confused.
Can you elaborate on what you would like me to check for?

[NobodyXu]

Also, I think you would have to do the same filtering/nulling of workspace dependencies in the Cargo.toml files, as you can have dependencies such as workspace-crate = { path = "path/for/local/development", version = "1.0.0-version-for-installing-via-cratesio" }

Thanks!
I've updated the PR and also sort the objects before using JSON.stringify to convert them to strings for hashing.

[Swatinem]

Sorry I am confused. Can you elaborate on what you would like me to check for?

By that I mean the summary information that is printed by the action, this thing here:

Cache Configuration
  Workspaces:
      /home/runner/work/rust-cache/rust-cache/tests
  Cache Paths:
      /home/runner/.cargo
      /home/runner/work/rust-cache/rust-cache/tests/target
  Restore Key:
      v0-rust-coverage-0308f3c6
  Cache Key:
      v0-rust-coverage-0308f3c6-f80d3fb4
  .. Prefix:
    - v0-rust-coverage
  .. Environment considered:
    - Rust Version: 1.69.0 x86_64-unknown-linux-gnu (84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc)
    - CARGO_INCREMENTAL
    - CARGO_TERM_COLOR
  .. Lockfiles considered:
    - /home/runner/work/rust-cache/rust-cache/tests/Cargo.lock
    - /home/runner/work/rust-cache/rust-cache/tests/Cargo.toml
    - /home/runner/work/rust-cache/rust-cache/tests/wasm-workspace/Cargo.lock
    - /home/runner/work/rust-cache/rust-cache/tests/wasm-workspace/Cargo.toml
    - /home/runner/work/rust-cache/rust-cache/tests/wasm-workspace/crates/one/Cargo.toml
    - /home/runner/work/rust-cache/rust-cache/tests/wasm-workspace/crates/two/Cargo.toml

It should still list these files in the "lockfiles considered" section. Even though you are not hashing the literal file, but rather using more targeted information from them.

[NobodyXu]

It should still list these files in the "lockfiles considered" section. Even though you are not hashing the literal file, but rather using more targeted information from them.

Thanks!
I've fixed this by adding these files to self.keyFiles after hashing is done.

[NobodyXu]

@Swatinem Sorry I forgot to update the dist/ using npm run prepare, I've updated it now and it should be ready to merge.

[Swatinem]

Thanks for sticking with this, great work!