Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support form tag #1502

Merged
merged 1 commit into from
Mar 20, 2023
Merged

support form tag #1502

merged 1 commit into from
Mar 20, 2023

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Mar 13, 2023

Describe the PR
This is a completed way to support form tag.
As the extensions of schema only marshal keys with prefix x- into json, so I just add the form tag name with key form into the schema extensions, and look it up when parsing @param.
And this way also doesn't affect the final output docs.

Relation issue
#1422

Signed-off-by: sdghchj <sdghchj@qq.com>
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (19ddb4d) 85.15% compared to head (e28806e) 85.20%.

❗ Current head e28806e differs from pull request most recent head 3034d07. Consider uploading reports for the commit 3034d07 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
+ Coverage   85.15%   85.20%   +0.04%     
==========================================
  Files          19       19              
  Lines        3630     3642      +12     
==========================================
+ Hits         3091     3103      +12     
  Misses        460      460              
  Partials       79       79              
Impacted Files Coverage Δ
field_parser.go 96.93% <100.00%> (+0.03%) ⬆️
operation.go 96.14% <100.00%> (+0.02%) ⬆️
parser.go 94.52% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ubogdan ubogdan merged commit 3f0a4b0 into master Mar 20, 2023
@ubogdan ubogdan deleted the formData branch March 20, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants