Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): address getting configUrl from options #9840

Merged
merged 4 commits into from
Apr 18, 2024
Merged

fix(config): address getting configUrl from options #9840

merged 4 commits into from
Apr 18, 2024

Conversation

glowcloud
Copy link
Contributor

Refs #9819

@glowcloud glowcloud requested a review from char0n April 18, 2024 11:09
@glowcloud glowcloud self-assigned this Apr 18, 2024
char0n
char0n approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@glowcloud glowcloud merged commit dc9650b into master Apr 18, 2024
8 checks passed
@glowcloud glowcloud mentioned this pull request Apr 18, 2024
Closed
@char0n char0n deleted the issue-9819 branch April 19, 2024 06:29
@leika leika mentioned this pull request May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char0n char0n char0n approved these changes

Assignees

@glowcloud glowcloud

Labels
type: enhancement version: 5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glowcloud @char0n