Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Curl Example to height of 400px. #9179

Merged
merged 2 commits into from Mar 7, 2024
Merged

Conversation

WillFM
Copy link
Contributor

@WillFM WillFM commented Aug 29, 2023

Limit height of curl text to 400px, so you don't have to scroll for days to get to results in the case where you have a huge payload.

Motivation and Context

Sometimes your payloads are huge, and the curl output muddle up finding the response output.

How Has This Been Tested?

I've been using a chrome override to add the rule for ages. But getting tired of generating overrides for new websites, rather it just be the default.

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Limit Hight of curl text to 400px, so you don't have to scroll for days to get to results in the case where you have a huge payload.
Copy link
Contributor

@glowcloud glowcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change!
I checked it out on different browsers with the default PetStore definition, everything looks good to me. This value for max-height is also consistent with the one for HighlightCode component, so seems like a fine value.

Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glowcloud glowcloud merged commit 6dbcd45 into swagger-api:master Mar 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants