fix(icons): allow SVG icons to receive arbitrary props #9106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These arbitrary props will allow to handle
native React element events among other things.
Refs #9094
This PR supersedes the #9097
Motivation and Context
In order to have fully utilizable SVG icons, we need to make them open to extension via arbitrary prop passing. One of the many things this arbitrary props passing allows is to handle native React element events.
Other things that have been done in this PR:
unlock-auth.jsx
andlock-auth.jsx
have been renamed tounlock-auth-icon.jsx
andlock-auth-icon.jsx
LockAuthIcon
andUnlockAuthIcon
has been transformed into class components to allow defining custommapStateToProps
which SwaggerUI plugin system calls to determine theownProps
of the container. TheseownProps
are then passed to underlying SVG icon component without all the system container clutter.unlock-auth-operation.jsx
andunlock-auth-operation.jsx
have been dropped as it is satisfactory to just create the aliases during the plugin registration.Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests