Add test to expose issue 1572 - spaces in path to doc using relative server #1893
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Test failure as expected. |
ind1go
force-pushed
the
bug/1572-spaces-in-doc-path
branch
from
c0518a0 to
884b47a
Compare
|
✅ Fix added to check that the server URL has both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1572 shows that when a document is read from a location with spaces (or other URI-invalid characters) and has a relative server path, an error parsing the document occurs.
This PR starts by exposing the issue through a new test.
It then adds a check that both
{and}occur in the server URL before attempting to replace variables in it, which avoids theIndexOutOfBoundsExceptionin the case where no, there's no variable.