Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolver: utilize ApiDOM's async plugins dispatcher and visitor merger #3455

Closed
char0n opened this issue Apr 4, 2024 · 2 comments
Closed

resolver: utilize ApiDOM's async plugins dispatcher and visitor merger #3455

char0n opened this issue Apr 4, 2024 · 2 comments
Assignees
@char0n
Labels
cat: resolver type: bug version: 3.x

Comments

@char0n
Copy link
Member

char0n commented Apr 4, 2024

Our OpenAPI 3.1.0 dereference strategy implemented in this repo is merging sync visitor with async ones. Sync visitor merging mechanism is used and this fact alone is causing various side effects.

Another thing is async plugins dispatch - it's best to always use async version of plugins dispatch mechanism. We use plugins from ApiDOM and we have no idea if they change from sync to async in the future.
@char0n char0n self-assigned this Apr 4, 2024
@char0n
Copy link
Member Author

char0n commented Apr 4, 2024

Another thing is async plugins dispatch - it's best to always use async version of plugins dispatch mechanism. We use plugins from ApiDOM and we have no idea if they change from sync to async in the future.

Will be addressed upstream by swagger-api/apidom#4008

char0n added a commit that referenced this issue Apr 4, 2024
@char0n
fix(resolver): fix side effects in OpenAPI 3.1.0 resolving
d290d9d 
Refs #3455
@char0n char0n mentioned this issue Apr 4, 2024
Merged
@char0n
Copy link
Member Author

char0n commented Apr 4, 2024

Our OpenAPI 3.1.0 dereference strategy implemented in this repo is merging sync visitor with async ones. Sync visitor merging mechanism is used and this fact alone is causing various side effects.

Addressed in #3456

char0n added a commit that referenced this issue Apr 4, 2024
@char0n
fix(resolver): fix side effects in OpenAPI 3.1.0 resolving (#3456)
1631813 
Refs #3455
@char0n char0n closed this as completed Apr 4, 2024
swagger-bot pushed a commit that referenced this issue Apr 4, 2024
@semantic-release-bot
chore(release): cut the 3.26.5 release [skip ci]
8128a09 
## [3.26.5](v3.26.4...v3.26.5) (2024-04-04)

### Bug Fixes

* **resolver:** fix side effects in OpenAPI 3.1.0 resolving ([#3456](#3456)) ([1631813](1631813)), closes [#3455](#3455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
cat: resolver type: bug version: 3.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@char0n