Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace node-sass with sass. #453

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Replace node-sass with sass. #453

merged 2 commits into from
Apr 7, 2021

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Apr 1, 2021

Node-sass is deprecated.

@jkphl there's a slight difference between node-sass and sass regarding sass.render (the sync method): https://github.com/sass/dart-sass#javascript-api

Note however that by default, renderSync() is more than twice as fast as render() due to the overhead of asynchronous callbacks. To avoid this performance hit, render() can use the fibers package to call asynchronous importers from the synchronous code path. To enable this, pass the Fiber class to the fiber option:

It seems things are OK without fibers though, so I skipped it for now.

Node-sass is deprecated.
@XhmikosR XhmikosR added the dependencies Pull requests that update a dependency file label Apr 1, 2021
@XhmikosR XhmikosR merged commit f47dfb4 into master Apr 7, 2021
@XhmikosR XhmikosR deleted the sass branch April 7, 2021 06:10
XhmikosR added a commit that referenced this pull request Aug 22, 2021
Node-sass is deprecated.
XhmikosR added a commit that referenced this pull request Aug 22, 2021
Node-sass is deprecated.
XhmikosR added a commit that referenced this pull request Aug 22, 2021
Node-sass is deprecated.
XhmikosR added a commit that referenced this pull request Oct 1, 2021
Node-sass is deprecated.
XhmikosR added a commit that referenced this pull request Oct 1, 2021
Node-sass is deprecated.
Kreeg pushed a commit to Kreeg/svg-sprite that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant