-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move component methods out of constructor #139
Comments
I'm not sure that's strictly true – with That said, there are some benefits to moving component methods out of the constructor, particularly when we get round to externalising methods and helpers that can be shared between components. |
That works too, I'm just complaining because closure-compiler doesn't seem to like assigning methods to |
There is already work towards this goal in #37, in the first place for the generated template code. |
@Swatinem Yeah, I guess when I changed the direction of the issue it made it a duplicate. |
Instead of doing
this.fire =
,this.get =
, etc we should move the component methods out of the constructor.The text was updated successfully, but these errors were encountered: