Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update README for v1 #665

Merged
merged 2 commits into from
Feb 25, 2025
Merged

chore: update README for v1 #665

merged 2 commits into from
Feb 25, 2025
+91 −128

Conversation

baseballyama
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025 •
edited
Loading

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/svelte-eslint-parser@665

Published Instant Preview Packages:

View Commit

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b679b4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

coveralls commented Feb 9, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13226201530

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.653%
Totals Coverage Status
Change from base Build 13212266836: 0.0%
Covered Lines: 10463
Relevant Lines: 10930
💛 - Coveralls

@baseballyama baseballyama force-pushed the chore/readme branch 2 times, most recently from 1ac2344 to a92fdca Compare February 9, 2025 07:13
@baseballyama
chore: update README
Loading
Loading status checks…
2b64365
@baseballyama baseballyama mentioned this pull request Feb 9, 2025
Merged
ota-meshi
ota-meshi requested changes Feb 9, 2025
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!!!

README.md Outdated
1. Write `parser` option into your ESLint Config file.
2. Use glob patterns or `--ext .svelte` CLI option.
1. In your ESLint config, set the `parser` option to `svelte-eslint-parser`.
2. Use glob patterns or the `--ext .svelte` CLI option to include `.svelte` files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the --ext option cannot be used in a flat config, it seems necessary to remove the related sentence.
https://eslint.org/docs/latest/use/command-line-interface#--ext

Copy link
Member Author

@baseballyama baseballyama Feb 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... Thank you! fixed: b679b4d

README.md Outdated
# or
$ eslint src --ext .svelte
eslint src --ext .svelte
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See another comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed: b679b4d

@baseballyama
remove --ext
Loading
Loading status checks…
b679b4d
ota-meshi
ota-meshi approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@baseballyama
Copy link
Member Author

Please release v1 at your own timing.🎉🎉🎉

@baseballyama baseballyama merged commit fbad19b into main Feb 25, 2025
12 checks passed
@baseballyama baseballyama deleted the chore/readme branch February 25, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baseballyama @coveralls @ota-meshi