Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A survey validates questions on clicking Preview rather than Complete when checkErrorsMode is "onComplete" #6608

Closed
JaneSjs opened this issue Jul 27, 2023 · 1 comment · Fixed by #6638
Closed

A survey validates questions on clicking Preview rather than Complete when checkErrorsMode is "onComplete" #6608

JaneSjs opened this issue Jul 27, 2023 · 1 comment · Fixed by #6638
Assignees
@andrewtelnov
Labels
bug user issue An issue or bug reported by users
Milestone
v1.9.102

Comments

@JaneSjs
Copy link
Contributor

JaneSjs commented Jul 27, 2023

User issue: T14029 - Ignore validation to navigate to next page but keeping the error messages
https://surveyjs.answerdesk.io/internal/ticket/details/T14029

Regardless of the checkErrorsMode: "onComplete" setting, a survey validates questions when a user clicks Preview, not when the user completes a survey.
View Demo

Purposed solution: when checkErrorsMode: "onComplete", validate question answers when a user completes a survey.
@JaneSjs JaneSjs added bug user issue An issue or bug reported by users labels Jul 27, 2023
andrewtelnov added a commit that referenced this issue Aug 2, 2023
@andrewtelnov
checkErrorsMode = "onComplete" - A survey validates questions when us…
209bcfc 
…ers click Preview rather than when they complete the survey fix #6608
@andrewtelnov andrewtelnov mentioned this issue Aug 2, 2023
Merged
tsv2013 pushed a commit that referenced this issue Aug 3, 2023
@andrewtelnov
checkErrorsMode = "onComplete" - A survey validates questions when us…
6aea5c9 
…ers click Preview rather than when they complete the survey fix #6608 (#6638)
@RomanTsukanov RomanTsukanov changed the title checkErrorsMode = "onComplete" - A survey validates questions when users click Preview rather than when they complete the survey When checkErrorsMode is "onComplete", a survey validates questions when users click Preview rather than when they complete the survey Aug 9, 2023
@andrewtelnov andrewtelnov added this to the v1.9.102 milestone Aug 9, 2023
@RomanTsukanov RomanTsukanov changed the title When checkErrorsMode is "onComplete", a survey validates questions when users click Preview rather than when they complete the survey A survey validates questions on clicking Preview rather than Complete when checkErrorsMode is "onComplete" Aug 9, 2023
@JaneSjs
Copy link
Contributor Author

JaneSjs commented Aug 10, 2023

@andrewtelnov Andrew, unfortunately, with v1.9.102, a survey doesn't validate answers on completion.

https://codesandbox.io/s/sad-kapitsa-cfyhlx?file=/src/json.js

The expected behavior: when a user clicks Complete, a survey notifies the user that question1 accepts only numeric values. However, this doesn't happen and a survey is simply completed.

@JaneSjs JaneSjs reopened this Aug 10, 2023
andrewtelnov added a commit that referenced this issue Aug 10, 2023
@andrewtelnov
Fix the issue with checking error after preview #6608
9f7aecf
novikov82 pushed a commit that referenced this issue Aug 10, 2023
@andrewtelnov
Fix the issue with checking error after preview #6608 (#6691)
36d3a48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewtelnov andrewtelnov

Labels
bug user issue An issue or bug reported by users
Projects
None yet
Milestone
v1.9.102
Development

Successfully merging a pull request may close this issue.

checkErrorsMode = "onComplete" - A survey validates questions when us… surveyjs/survey-library
2 participants
@andrewtelnov @JaneSjs