fix: make line prop works as expected #530
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @dxsun97 👋 Thanks for taking the time to open this PR 🔥 I'll check it and will release a new version this weekend! |
suren-atoyan
approved these changes
Oct 6, 2023
|
this is published - check the latest version 4.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #367
the
lineprop inEditorwill not take effect when the editor is mounted, it only works when the line prop changes, I think it doesn't do what the documentation expects.here is a repo: https://codesandbox.io/s/monaco-react-line-prop-y7jvvd?file=/src/App.tsx