Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Posting undo of a "like" to the inbox may result in 500 internal server error #2896

Open
rnwgnr opened this issue May 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@rnwgnr
Copy link

rnwgnr commented May 5, 2024

Describe the bug with a clear and concise description of what the bug is.

Just interpreting the logs:
When a remote instance tries to "undo" a like but that activity never reached the local instance for some reason, the request fails with a 500

Log entries:

timestamp="2024-05-04 01:00:23.407" func=server.glob..func1.Logger.func13.1 level=ERROR latency="11.64543ms" userAgent="Friendica 'Yellow Archangel' 2024.03-1557; https://social.alfredbuehler.ch" method=POST statusCode=500 path=/users/rwa/inbox clientIP=2a00:1128:1:1::157:84 pubKeyID=https://social.alfredbuehler.ch/profile/abu#main-key errors="Error #01: PostInboxScheme: error calling sideEffectActor.PostInbox: Undo: error undoing like: undoLike: error converting ActivityStreams Like to fave: getASObjectStatus: error getting object account from database: sql: no rows in result set\n" requestID=wf6htgcf040006t20ak0 msg="Internal Server Error: wrote 33B"
timestamp="2024-05-04 01:00:28.535" func=server.glob..func1.Logger.func13.1 level=ERROR latency="7.773366ms" userAgent="Friendica 'Yellow Archangel' 2024.03-1557; https://social.alfredbuehler.ch" method=POST statusCode=500 path=/users/rwa/inbox clientIP=2a00:1128:1:1::157:84 pubKeyID=https://social.alfredbuehler.ch/profile/abu#main-key errors="Error #01: PostInboxScheme: error calling sideEffectActor.PostInbox: Undo: error undoing like: undoLike: error converting ActivityStreams Like to fave: getASObjectStatus: error getting object account from database: sql: no rows in result set\n" requestID=y3ghtgcf04000g5f5kxg msg="Internal Server Error: wrote 33B"

What's your GoToSocial Version?

v0.15.0

GoToSocial Arch

arm64 binary

What happened?

No response

What you expected to happen?

The request should not result in a "internal server error" but rather be handled gracefully.

The remote instance will otherwise retry quite a few times.

How to reproduce it?

No response

Anything else we need to know?

No response

@rnwgnr rnwgnr added the bug Something isn't working label May 5, 2024
@tsmethurst
Copy link
Contributor

Ah thanks, we just need to mask that error I think.

@tsmethurst tsmethurst changed the title [bug] undoing a "like" may result in 500 internal server error [bug] Posting undo of a "like" to the inbox may result in 500 internal server error May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants