Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condition to check nuxt on deps for detecting nuxt apps #3868

Merged
merged 8 commits into from
Aug 27, 2024

Conversation

schirrel
Copy link
Contributor

Fix bug on detecting Nuxt apps that uses package.json devDependencies only, instead it uses nuxt as dependencies.

Change Summary

When trying to launch nuxt 3 app it is not being detected as Nuxt as stated in Fly.io docs.
After research found this initial bug, but the fix in there did not indeed fixed the problem.

Fixed by adding extra validation to flyctl/scanner/jsFramework.go to check both dependencies and devDependencies property for nuxt apps.

Related to:
#3867

Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fix bug on detecting Nuxt apps that uses package.json `devDependencies` only, instead it uses `nuxt` as `dependencies`.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@schirrel
Copy link
Contributor Author

sorry to bother you guys @dangra @rubys @lubien but if you have time could one of you take a look into this, i'd appreciate 🙏🏻

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@schirrel
Copy link
Contributor Author

sorry to bother you guys @kzys @billyb2 @jsierles but if you have time could one of you take a look into this, i'd appreciate 🙏🏻

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@rubys rubys merged commit c00fb27 into superfly:master Aug 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants