Add condition to check nuxt on deps for detecting nuxt apps #3868
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug on detecting Nuxt apps that uses package.json
devDependencies
only, instead it usesnuxt
asdependencies
.Change Summary
When trying to launch nuxt 3 app it is not being detected as Nuxt as stated in Fly.io docs.
After research found this initial bug, but the fix in there did not indeed fixed the problem.
Fixed by adding extra validation to flyctl/scanner/jsFramework.go to check both
dependencies
anddevDependencies
property for nuxt apps.Related to:
#3867
Documentation