Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bash shell completion fails #10

Closed
superatomic opened this issue Aug 5, 2023 · 0 comments · Fixed by #12
Closed

Bash shell completion fails #10

superatomic opened this issue Aug 5, 2023 · 0 comments · Fixed by #12
Assignees
@superatomic
Labels
bug Something isn't working

Comments

@superatomic
Copy link
Owner

Click shell completion for bash has been silently failing to generate when installed through the tldr-man Homebrew formula.

This bug was discovered when changes to generate_completions.sh in 90eef34 made this error fatal and broke Homebrew HEAD builds (brew install --HEAD superatomic/tap/tldr-man). Before this, empty files were being installed as bash completion scripts, instead of the intentional scripts.

This issue occurs because the only version of Bash that is present during a Homebrew formula build is too old to work with click (bash <4.4). For more information, see pallets/click#2574.

Merging pallets/click#2576 will fix this issue.
@superatomic superatomic added the bug Something isn't working label Aug 5, 2023
@superatomic superatomic self-assigned this Aug 5, 2023
superatomic added a commit that referenced this issue Aug 7, 2023
@superatomic
Patch click Bash completion generation
ecbf2be 
Fix for #10
@superatomic superatomic mentioned this issue Aug 7, 2023
Merged
superatomic added a commit that referenced this issue Aug 7, 2023
@superatomic
Patch click Bash completion generation (#11)
cec3e33 
Fix for #10
superatomic added a commit that referenced this issue Aug 7, 2023
@superatomic
Patch click Bash completion generation (#11)
00c8578 
Fix for #10
superatomic added a commit that referenced this issue Aug 18, 2023
@superatomic
Remove patch for Click Bash completion
f24d018 
Introduced in #11. See #10.
@superatomic superatomic linked a pull request Aug 18, 2023 that will close this issue
Fix broken bash shell completion #12
Merged
@superatomic superatomic mentioned this issue Aug 18, 2023
Merged
superatomic added a commit that referenced this issue Aug 18, 2023
@superatomic
Fix broken bash shell completion (#12)
a9662e1 
* Update the minimum Click version from `8.1.3` to `8.1.7`

* Remove patch for Click Bash completion

Introduced in #11. See #10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@superatomic superatomic

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken bash shell completion superatomic/tldr-man
1 participant
@superatomic