Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ignore github_conf in jscpd #5533

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

massongit
Copy link
Contributor

@massongit massongit commented Apr 15, 2024

Proposed changes

https://github.com/super-linter/super-linter/actions/runs/8674328025/job/23786540069

  2024-04-13 15:06:04 [INFO]   Linting JSCPD items...
  2024-04-13 15:06:05 [ERROR]   Found errors when linting JSCPD. Exit code: 1.
  2024-04-13 15:06:05 [INFO]   Command output for JSCPD:
  ------
  Error: ENOENT: no such file or directory, open '/github/workspace/github_conf/branch_protection_rules.json'
      at Object.openSync (node:fs:581:18)
      at Object.readFileSync (node:fs:457:35)
      at addContentToEntry (/node_modules/@jscpd/finder/dist/files.js:68:32)
      at Array.map (<anonymous>)
      at Object.getFilesToDetect (/node_modules/@jscpd/finder/dist/files.js:94:10)
      at exports.detectClones (/node_modules/jscpd/dist/index.js:27:28)
      at Object.<anonymous> (/node_modules/jscpd/dist/index.js:70:28)
      at Generator.next (<anonymous>)
      at /node_modules/jscpd/dist/index.js:8:71
      at new Promise (<anonymous>) {
    errno: -2,
    code: 'ENOENT',
    syscall: 'open',
    path: '/github/workspace/github_conf/branch_protection_rules.json'
  }

checkov creates a github_conf directory at runtime (See CKV_GITHUB_CONF_DIR_NAME Section in https://www.checkov.io/7.Scan%20Examples/Github.html ).
An error occurs if jscpd reads this.
Therefore, I ignore this from the running target of jscpd.

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@massongit massongit marked this pull request as ready for review April 16, 2024 00:08
@ferrarimarco ferrarimarco added this pull request to the merge queue Apr 16, 2024
@ferrarimarco
Copy link
Collaborator

Thanks!

Merged via the queue into super-linter:main with commit 0873f46 Apr 16, 2024
44 checks passed
@massongit massongit deleted the ignore_github_conf branch April 16, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants