Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export TEST_CASE_RUN #5499

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Export TEST_CASE_RUN #5499

merged 1 commit into from
Apr 8, 2024

Conversation

ferrarimarco
Copy link
Collaborator

Proposed changes

Export the TEST_CASE_RUN variable because subprocesses reference it when building the file list.

Fix #5483

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label labels Apr 8, 2024
@ferrarimarco ferrarimarco self-assigned this Apr 8, 2024
@ferrarimarco ferrarimarco changed the title fix: export test_case_run Export TEST_CASE_RUN Apr 8, 2024
- Export the TEST_CASE_RUN variable because subprocesses reference it
  when building the file list.
- Remove a duplicate file that we didn't catch because Jscpd was not
  running due to the TEST_CASE_RUN variable not being exported.

Fix #5483
@ferrarimarco ferrarimarco merged commit cb109f4 into main Apr 8, 2024
87 checks passed
@ferrarimarco ferrarimarco deleted the export-test-case-run branch April 8, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSCPD Doesn't Run Unless TEST_CASE_RUN is set
1 participant