-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint Go modules #4984
Lint Go modules #4984
Conversation
The variable option is not useful because of following two reasons. I propose a recursive search for a |
True. It's still worth having it to maintain backward compatibility with the current behavior.
I don't get
That's a nice idea. With this, the |
3f536b2
to
3bf7b72
Compare
72a4e27
to
06498c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Fixes #3596
Fixes #4430
Proposed Changes
VALIDATE_GO_MODULES
, defaults totrue
, to enable the this new mode.Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large, fundamental change.automation
,bug
,documentation
,enhancement
,infrastructure
.BEGIN_COMMIT_OVERRIDE
feat: lint Go modules (#4984)
END_COMMIT_OVERRIDE