Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify multi status checks #4958

Merged
merged 6 commits into from
Dec 14, 2023
Merged

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Dec 7, 2023

Proposed Changes

  1. Simplify the conditions to enable validation of the variables that we need to submit status checks. These checks and related logging run only if MULTI_STATUS=true and RUN_LOCAL=false.
  2. Avoid emitting confusing message logs about status reports when RUN_LOCAL=false.

Readiness Checklist

Author/Contributor

  • I included all the needed documentation for this change.
  • I provided the necessary tests.

Reviewing Maintainer

  • Label as breaking if this is a large, fundamental change.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

BEGIN_COMMIT_OVERRIDE
fix: simplify multi status checks (#4958)
END_COMMIT_OVERRIDE

@ferrarimarco ferrarimarco added infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label labels Dec 7, 2023
@ferrarimarco ferrarimarco self-assigned this Dec 7, 2023
@ferrarimarco
Copy link
Collaborator Author

We need #4960 before this one.

@ferrarimarco
Copy link
Collaborator Author

@zkoppert going ahead with this one because it's a simple change so you can focus on reviewing other PRs :)

@ferrarimarco ferrarimarco merged commit e6e6e1f into main Dec 14, 2023
3 checks passed
@ferrarimarco ferrarimarco deleted the simplify-multi-status-checks branch December 14, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant