Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add functions property #579

Merged
merged 4 commits into from
Oct 4, 2023
Merged

feat: add functions property #579

merged 4 commits into from
Oct 4, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Oct 3, 2023

What kind of change does this PR introduce?

see title, to fully remove in v1.3.0. Address #576

  • need to update docs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@J0 J0 requested review from olirice and silentworks as code owners October 3, 2023 14:14

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@J0 J0 requested a review from anand2312 October 3, 2023 14:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@silentworks silentworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also reset the self._functions to None whenever an event fires inside of

def _listen_to_auth_events(self, event: AuthChangeEvent, session):

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@J0
Copy link
Contributor Author

J0 commented Oct 4, 2023

Added

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (11b014d) 71.50% compared to head (c283c8c) 69.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
- Coverage   71.50%   69.54%   -1.97%     
==========================================
  Files           9        9              
  Lines         186      197      +11     
==========================================
+ Hits          133      137       +4     
- Misses         53       60       +7     
Files Coverage Δ
supabase/client.py 68.42% <45.45%> (-4.20%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J0 J0 requested a review from silentworks October 4, 2023 06:40
@J0 J0 merged commit 7cf9f84 into main Oct 4, 2023
@silentworks silentworks deleted the j0/convert_functions_into_property branch October 4, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants